Signup: DSS: Only show previews when images are loaded #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirbrillig
changed the title
sirbrillig
force-pushed
the
update/dss-with-image-preloader
branch
from
fac300c
to
774b924
Compare
sirbrillig
force-pushed
the
update/dss-with-image-preloader
branch
3 times, most recently
from
25505ab
to
a1e43a5
Compare
sirbrillig
added
[Status] Needs Review
|
ping @kwight for review |
|
This works and feels much more consistent and solid now; I'm still seeing the images load in pieces during the repaint, but it always seems consistent. After discussion with @sirbrillig , he'll do a separate PR for adding a delay to the removal of the white overlay, and we should hopefully have the experience we've been going for. LGTM 👍 |
kwight
added
[Status] Ready to Merge
and removed
[Status] Needs Review
sirbrillig
added a commit
that referenced
this pull request
Dec 3, 2015
Signup: DSS: Only show previews when images are loaded
This was referenced Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now DSS images load slowly. We try to handle this by waiting ~250ms before showing the preview, but depending on the browser and the connection speed, that may not be enough. It would be nice to avoid this guessing game.
Part of fixing #1163
Here we use a hidden
ImagePreloaderto load the image onto the page and track when it is complete. Once the image has been loaded by the browser, then we update the images in the previews.Testing
Load http://calypso.localhost:3000/start/dss/ and try searching for words. Make sure that the images load correctly and with very little or no flicker of unstyled previews (the amount of DOM changes still may cause a short flicker).