Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themes: Add README.md to Themes state dir #12201

Merged
merged 8 commits into from
Apr 21, 2017
Merged

Themes: Add README.md to Themes state dir #12201

merged 8 commits into from
Apr 21, 2017

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Mar 15, 2017 •
edited
Loading

See prose 🙂

@ockham ockham self-assigned this Mar 15, 2017
@matticbot
Copy link
Contributor

matticbot commented Mar 15, 2017 •
edited by folletto
Loading

Test live: https://calypso.live/?branch=add/themes-state-docs

Probably more like: https://github.com/Automattic/wp-calypso/blob/add/themes-state-docs/client/state/themes/README.md

@folletto folletto added this to the Themes: JetPress Rally milestone Mar 21, 2017
@matticbot matticbot added the [Size] M Medium sized issue label Mar 24, 2017
@ockham ockham added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Apr 19, 2017
@folletto
Copy link
Contributor

Read through it, looks good. Just a minor syntax detail: the first paragraph introduces a list, but there's only one point in the list. I'd add one, or just make it a normal paragraph without intro.

The text is clear.

@ockham ockham force-pushed the add/themes-state-docs branch from 2a76a50 to d8a1ecd Compare April 21, 2017 14:30
@folletto
Copy link
Contributor

Solid :shipit:

@folletto folletto added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 21, 2017
@ockham
Copy link
Contributor Author

ockham commented Apr 21, 2017

Thanks! Pushed another minor copy fix, will merge now.

@ockham ockham merged commit 834a168 into master Apr 21, 2017
@ockham ockham deleted the add/themes-state-docs branch April 21, 2017 18:46
@awaisab172 awaisab172 mentioned this pull request Nov 30, 2023
Open
@awaisab172 awaisab172 mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@folletto folletto Awaiting requested review from folletto

@seear seear Awaiting requested review from seear

@budzanowski budzanowski Awaiting requested review from budzanowski

Assignees

@ockham ockham

Labels
Documentation [Feature Group] Appearance & Themes Features related to the appearance of sites. [Size] M Medium sized issue
Projects
None yet
Milestone
Themes: JetPress Rally
Development

Successfully merging this pull request may close these issues.
3 participants
@ockham @matticbot @folletto