Invites: Filter invite object and decode entities #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebinnion
added
[Status] Needs Review
|
|
||
| const initialState = fromJS( { | ||
| list: {}, | ||
| errors: {} | ||
| } ); | ||
|
|
||
| function filterObject( object ) { |
There was a problem hiding this comment.
could we change the name of this function for something more descriptive? something like decodeProperties or decodeObjectProperties or similar? with filterObject you don't really get what it does unless you look at the code of the function
|
It works fine! I left a minor comment about variable naming, but appart from that it's ready to merge... if you're agree with me, change the name & merge, and if not, merge right away! :D |
johnHackworth
added
[Status] Ready to Merge
and removed
[Status] Needs Review
ebinnion
force-pushed
the
update/invites-html-entities
branch
from
4ada758
to
d59e0ab
Compare
ebinnion
added a commit
that referenced
this pull request
Dec 4, 2015
Invites: Filter invite object and decode entities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR filters an invite and ensures that all value are decoded. Addresses #1086
To test:
update/invites-html-entities$site/wp-admin/users.php?page=wpcom-invite-users$invite_key/accept-invite/$site/$invite_keywhere$sitehas an entity in its nameNote: Decoding the user object is now taking place in #1257, so the entities showing in the below screenshot are OK.