Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

People: Invites: Normalize get invite api response #1267

Merged
merged 5 commits into from
Dec 4, 2015
Merged

People: Invites: Normalize get invite api response #1267

merged 5 commits into from
Dec 4, 2015

Conversation

lezama
Copy link
Contributor

@lezama lezama commented Dec 4, 2015

Derived from #1261

How to test

  • checkout update/invites-process-api-data
  • both logged in and logged out flows should still work

@lezama lezama added this to the People Management: m6 milestone Dec 4, 2015
@lezama lezama self-assigned this Dec 4, 2015
@lezama lezama added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] In Progress and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 4, 2015
@roccotripaldi
Copy link
Member

This looks much cleaner!
You missed the autofill email: https://github.com/Automattic/wp-calypso/blob/update/invites-process-api-data/client/my-sites/invites/invite-accept-logged-out/index.jsx#L113

Other than that, i'd say it is ready to ship.

@lezama lezama force-pushed the update/invites-process-api-data branch from 15f132f to b0cca40 Compare December 4, 2015 17:03
@lezama lezama force-pushed the update/invites-process-api-data branch from b0cca40 to e76bd5d Compare December 4, 2015 18:54
ebinnion
ebinnion reviewed Dec 4, 2015
View reviewed changes
client/my-sites/invites/invite-header/index.jsx
this.props.blog_details
? <Site site={ this.props.blog_details } />
this.props.site
? <Site site={ this.props.site } />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line and the one below should be indented one more tab.

@lezama lezama added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Dec 4, 2015
@ebinnion ebinnion added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 4, 2015
lezama added a commit that referenced this pull request Dec 4, 2015
@lezama
Merge pull request #1267 from Automattic/update/invites-process-api-data
d6f0193 
People: Invites: Normalize get invite api response
@lezama lezama merged commit d6f0193 into master Dec 4, 2015
@lezama lezama deleted the update/invites-process-api-data branch December 4, 2015 19:16
@snyk-bot snyk-bot mentioned this pull request Mar 17, 2020
Open
@mdno mdno mentioned this pull request Mar 22, 2024
Open
@apmarshall apmarshall mentioned this pull request Mar 22, 2024
Open
@mayuba mayuba mentioned this pull request Mar 22, 2024
Open
@anarh anarh mentioned this pull request Mar 22, 2024
Open
@awaisab172 awaisab172 mentioned this pull request Mar 23, 2024
Open
@ajesse11x ajesse11x mentioned this pull request Mar 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lezama lezama

Labels
People Management
Projects
None yet
Milestone
People Management: m6
Development

Successfully merging this pull request may close these issues.
4 participants
@lezama @roccotripaldi @ebinnion @scruffian