Me: Fix missing cancel button on email change notice #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnHackworth
added
[Type] Bug
| @@ -33,7 +33,7 @@ var LanguageSelector = require( 'components/forms/language-selector' ), | |||
| ReauthRequired = require( 'me/reauth-required' ), | |||
| twoStepAuthorization = require( 'lib/two-step-authorization' ), | |||
| user = require( 'lib/user' )(), | |||
| Notice = require( 'components/notice' ), | |||
| Notice = require( 'notices/notice' ), | |||
There was a problem hiding this comment.
@johnHackworth : it's good that you pinged me. We are getting completely rid of notices/notice.
I think the proper way to do this would be to use NoticeAction component.
But yeah, thir is our fault :)
Commit 5da0e74 changed used component and link broke. here we add component again
|
Now it should be: |
ebinnion
added a commit
that referenced
this pull request
Dec 4, 2015
…on-missing-from-my-account Me: Fix missing cancel button on email change notice
ebinnion
deleted the
fix/email-change-cancel-option-missing-from-my-account
branch
scruffian
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1271
(probably related with the chanegs in notices) we were missing the 'cancel' button in the 'email changed, waiting for confirmation' notice:
This PR adds the button again:
ping @aduth @ebinnion
ping @mtias & @artpi , because this bug could be related with the changes in notices?