FoldableCard: Allow custom action button icon #1670
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
icon
prop which allows theFoldableCard
action button icon to be changed. This will be used for a cog icon in #1126.Examples
icon="arrow-down"
#### `icon="cog"`
### Why not use `actionButton` and `actionButtonExpanded` props?
Although the action button can already be overridden using the
actionButton
andactionButtonExpanded
props, overriding those require that the user also recreates thebutton
andGridicon
and apply appropriate classes. Overriding the defaultactionButton
also removes the screen readerspan
element.To get the same functionality, you'd need to do something like:
With this change, the above can be achieved with:
This still applies the current CSS animation/transformation, so the icon will appear upside-down when the card is expanded.