Me: Fix disabled verfication buttons on mobile #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enejb
added
[Status] Needs Review
enejb
force-pushed
the
fix/me-2fa-buttons-mobile-disable-verf
branch
from
a4bb487 to
582dd17
Compare
enejb
changed the title
|
Happy to see this getting the same treatment as the setup interface. Looks good to me! |
|
Nice! |
enejb
force-pushed
the
fix/me-2fa-buttons-mobile-disable-verf
branch
2 times, most recently
from
eeab2ba to
b39cb2b
Compare
|
@ebinnion I am using the FormButton component everythings still looks the same as before. |
enejb
force-pushed
the
fix/me-2fa-buttons-mobile-disable-verf
branch
from
b39cb2b to
739eab5
Compare
|
LGTM. |
ebinnion
added
[Status] Ready to Merge
and removed
[Status] Needs Review
enejb
force-pushed
the
fix/me-2fa-buttons-mobile-disable-verf
branch
from
739eab5 to
ed0a3af
Compare
enejb
added a commit
that referenced
this pull request
Dec 18, 2015
…sable-verf Me: Fix disabled verfication buttons on mobile
lancewillett
removed
the
[Status] Needs Design Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some of the mobile button when canceling 2 Factor Authentication
Before:
After:
On a screen that is slightly bigger then 480px
Smaller then 480px;
To test
Visit http://calypso.localhost:3000/me/security/two-step
This PR implements the styles from decided on here #1642
cc: @ebinnion, @MichaelArestad, @rickybanister