Framework: fix AllSites selection flow via site-selector. #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't triggering the whole function, which means <Picker> wasn't properly changing the layout-focus and you could end up stuck with the picker opened.
mtias
added
[Type] Bug
|
By the way, I think this sort of worked before because in general you started from a different url, so the url change forced a layout-focus change. But if you start in an all sites view like |
|
Nice catch and fix! |
rralian
added
[Status] Ready to Merge
and removed
[Status] Needs Review
mtias
added a commit
that referenced
this pull request
Dec 17, 2015
Framework: fix AllSites selection flow via site-selector.
This was referenced Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't triggering the whole function, which means
<Picker>wasn't properly changing thelayout-focusand you could end up stuck with the picker open when trying to switch to all-sites.cc @rralian @aduth
By the way, I think there may be some optimizations to be done here in the order and computations done. Switching a site seems a bit slower than what it should be for me.