Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSR: Move anything not needed by the masterbar back to client #2270

Merged
merged 2 commits into from
Jan 12, 2016

Conversation

ehg
Copy link
Member

@ehg ehg commented Jan 11, 2016

This moves unused dependencies (on the server), back to client. It's the first part of #1551, in a later PR, we'll remove shared altogether.

Note that i18n-utils and its dependencies remain in shared, as it's used by both the client and server for user bootstrapping.

To test:

  • make run
  • Check there are no build errors
  • Check Calypso generally works (the e2e tests are nice for this)
  • Check the logged-out masterbar on /design works, and is SSRed

@ehg ehg self-assigned this Jan 11, 2016
@ehg ehg added this to the Themes: Showcase M3-LoggedOut milestone Jan 11, 2016
@ehg ehg added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Jan 11, 2016
@ockham
Copy link
Contributor

ockham commented Jan 11, 2016

I aged for 'shared/components', 'shared/dispatcher', 'shared/lib', and 'shared/my-sites', and updated a number of occurrences (just docs).

@ockham
Copy link
Contributor

ockham commented Jan 11, 2016

Testing:

  • Check there are no build errors

  • Check Calypso generally works (the e2e tests are nice for this):
    Got 5 errors here, all of which were due to timeouts:

    • Error: Timed out waiting for first-name to be clearable
    • Error: Could not locate the .secure-payment-form element. Check that is is displayed.
    • Error: Could not locate the post preview component. Check that it is displayed (3 times)

    FWIW, trying master gave me 7 errors on, also all timeouts. I was able to manually invoke the secure payments form as well as the preview component for a post, a page, and a theme, so I guess the e2e timeouts were spurious. I'm not sure about the clearable first-name error; FWIW, I'm able to load a domain registration form.

  • Check the logged-out masterbar on /design works, and is SSRed

👍 if e2e tests pass for you

@ehg
Copy link
Member Author

ehg commented Jan 12, 2016

Thanks! :)

Got 5 errors here, all of which were due to timeouts

Yeah, I think that's expected. The upgrades/signup tests are kind of flaky, and I think the editor tests were just updated to take into account the new layout.

ehg and others added 2 commits January 12, 2016 12:00
Note that i18n-utils remains in `shared`, as it's used by both the
client and server for user bootstrapping.
@ehg ehg force-pushed the update/move-non-masterbar-shared-deps-to-client branch from f6ec8a9 to 3388a05 Compare January 12, 2016 12:00
ehg added a commit that referenced this pull request Jan 12, 2016
…ared-deps-to-client

SSR: Move anything not needed by the masterbar back to `client`
@ehg ehg merged commit 31e2328 into master Jan 12, 2016
@ehg ehg deleted the update/move-non-masterbar-shared-deps-to-client branch January 12, 2016 12:16
@ehg ehg removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. Server Side Rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants