Add UserMentionSuggestions block #24194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluefuton
added
[Status] In Progress
[Feature] Reader
|
bluefuton
force-pushed
the
add/block/user-mention-suggestions
branch
from
866e350 to
bdb34af
Compare
bluefuton
added
[Status] Needs Review
gwwar
reviewed
Apr 17, 2018
| import ExampleInput from './example-input'; | ||
| import withUserMentionSuggestions from '../with-user-mention-suggestions'; | ||
|
|
||
| const UserMentionSuggestionsExampleInput = ( { onKeyPress } ) => ( |
There was a problem hiding this comment.
Did we need to add an explicit displayName here for this example component too?
There was a problem hiding this comment.
It'll only ever be used inside UserMentionSuggestionsExample (to demonstrate how the HoC works), so should be alright without one I think.
gwwar
reviewed
Apr 17, 2018
config/test.json
Outdated
| @@ -84,6 +84,7 @@ | |||
| "reader/full-errors": true, | |||
| "reader/list-management": false, | |||
| "reader/new-post-notifications": true, | |||
| "reader/user-mention-suggestions": false, | |||
There was a problem hiding this comment.
Probably fine to enable for testing, should you want to add component tests.
gwwar
reviewed
Apr 17, 2018
| static propTypes = {}; | ||
|
|
||
| handleKeyPress = e => { | ||
| if ( e.target.value[ e.target.value.length - 1 ] === '@' ) { |
There was a problem hiding this comment.
I realize this is a placeholder, but I would suggest adding tests later to catch our desired cases. For example would we want word@name to trigger a highlight vs word @name?
gwwar
approved these changes
Apr 17, 2018
|
Thanks for the 👀 @gwwar! |
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new block,
UserMentionSuggestions, along with a higher-order component to wrap inputs and provide @ mention suggestions inside them.Background
We current have username suggestion for @mentions in the Editor only (implemented in #10142). This is the beginning of an effort to decouple that functionality from TinyMCE and make it usable anywhere in Calypso, including the Reader comments section and Conversations tool.
To test
Visit http://calypso.localhost:3000/devdocs/blocks/user-mention-suggestions and check your console. It doesn't do much yet :-)