Checkout: Add postal code field to Ebanx fields #24294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Feature] Checkout
ramonjd
commented
Apr 18, 2018
| @@ -36,24 +36,27 @@ export class EbanxPaymentFields extends Component { | |||
| const errorMessage = this.props.getErrorMessage( fieldName ) || []; | |||
| const isError = ! isEmpty( errorMessage ); | |||
|
|
|||
| return PAYMENT_PROCESSOR_EBANX_COUNTRIES[ this.props.countryCode ].fields.indexOf( fieldName ) > -1 | |||
| return PAYMENT_PROCESSOR_EBANX_COUNTRIES[ this.props.countryCode ].fields.indexOf( fieldName ) > | |||
| -1 | |||
| ? React.createElement( | |||
There was a problem hiding this comment.
These changes are auto-formatting only
designsimply
added
the
[Status] Needs Review
ramonjd
force-pushed
the
add/postal-code-field-to-ebanx-fields
branch
from
2d631c6 to
5a0762d
Compare
ramonjd
force-pushed
the
add/postal-code-field-to-ebanx-fields
branch
from
b789d75 to
1e1172b
Compare
|
es lint errors in CI will be addressed by #24308 |
…straction Updated validation and tests Updated styles for abstracted ebanx to ensure that fields look the same in redirect and credit card boxes
ramonjd
force-pushed
the
add/postal-code-field-to-ebanx-fields
branch
from
1e1172b to
fb13bf9
Compare
yoavf
added
[Status] Ready to Merge
and removed
[Status] Needs Review
4 tasks
|
@ramonjd Due to: ...there appears to be some extra padding in the credit card list item: Is it intended for a specific scope, or can it be removed? (Haven't tested this PR, but can't tell what it's for from the screenshot.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an omission in #24095, whereby the abstracted Ebanx component does not contain the required postal code field.
The inevitable result is that reusing the component won't contain all the required Ebanx fields.
There are no changes to design or functionality.
Screenshot
Testing
111.444.777-35)Expectations
At 3: You should see the normal credit card fields (including the post code field)
At 4: You should see the Ebanx extra fields
At 5: The fields should show validation messages
At 6: Valid form data should permit payment attempt