Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: update visual design of TinyMCE toolbar. #2466

Merged
merged 3 commits into from
Jan 20, 2016

Conversation

mtias
Copy link
Member

@mtias mtias commented Jan 15, 2016

Constrain it to the column width for a more airy feeling.

image

cc @kellychoffman

The breakpoint transition is not perfect, there's a gap where the toolbar shows without right-left borders but not full width.

@mtias mtias added [Feature] Post/Page Editor The editor for editing posts and pages. [Status] In Progress [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR labels Jan 15, 2016
@kellychoffman
Copy link
Member

The breakpoint transition is not perfect, there's a gap where the toolbar shows without right-left borders but not full width.

I changed it to start at 960px in 377707b to reduce the gap appearance.

mtias and others added 3 commits January 20, 2016 11:27
@mtias mtias force-pushed the update/editor-tinymce-bar branch from 6bdedc5 to 85a62dc Compare January 20, 2016 16:28
@mtias mtias added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Jan 20, 2016
@adambbecker
Copy link
Contributor

:shipit:

@adambbecker adambbecker added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 20, 2016
mtias added a commit that referenced this pull request Jan 20, 2016
Editor: update visual design of TinyMCE toolbar.
@mtias mtias merged commit eceb0b9 into master Jan 20, 2016
@mtias mtias deleted the update/editor-tinymce-bar branch January 20, 2016 21:31
@lancewillett lancewillett removed the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Post/Page Editor The editor for editing posts and pages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants