Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart: Remove animations on bars. #2490

Merged
merged 1 commit into from
Jan 18, 2016
Merged

Chart: Remove animations on bars. #2490

merged 1 commit into from
Jan 18, 2016

Conversation

timmyc
Copy link
Contributor

@timmyc timmyc commented Jan 15, 2016

Fixes #2485 - This branch removes the animation that happens in the chart bars on stats pages.

To Test

  • Open a site stats page
  • interact with the chart tabs, note the bars no longer animate on change

/cc @alternatekev & @jancavan I believe this is what we discussed doing, but hoping you both could weigh-in on this change.

@timmyc timmyc added [Feature] Stats Everything related to our analytics product at /stats/ [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR labels Jan 15, 2016
@timmyc timmyc self-assigned this Jan 15, 2016
@timmyc timmyc added this to the Stats: Maintenance milestone Jan 15, 2016
@jancavan
Copy link
Contributor

I didn't really think the animation served any purpose so this LGTM 👍

@jancavan jancavan added [Status] Ready to Merge and removed [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 18, 2016
timmyc added a commit that referenced this pull request Jan 18, 2016
Chart: Remove animations on bars.
@timmyc timmyc merged commit 90bc6fa into master Jan 18, 2016
@timmyc timmyc deleted the fix/stats/2485 branch January 18, 2016 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants