Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: add numberFormat to post performance. #2536

Merged
merged 1 commit into from
Jan 18, 2016
Merged

Stats: add numberFormat to post performance. #2536

merged 1 commit into from
Jan 18, 2016

Conversation

timmyc
Copy link
Contributor

@timmyc timmyc commented Jan 18, 2016

Though this file needs a good refactor to ES6 and tabs, that should all wait until #2384 lands. This however just fixes #2534 by adding numberFormat to the values shown in Post Performance on the Insights page.

stats_ _wordpress_com

To Test

  • View the site insights page for a high-traffic site
  • Verify that the large numbers have commas in the thousand place ( or whatever proper i18n formatting you would expect to see )

@timmyc timmyc added [Feature] Stats Everything related to our analytics product at /stats/ [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 18, 2016
@timmyc timmyc self-assigned this Jan 18, 2016
@timmyc timmyc added this to the Stats: Maintenance milestone Jan 18, 2016
@jblz jblz added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 18, 2016
@jblz
Copy link
Member

jblz commented Jan 18, 2016

👍

timmyc added a commit that referenced this pull request Jan 18, 2016
Stats: add numberFormat to post performance.
@timmyc timmyc merged commit e83e14c into master Jan 18, 2016
@timmyc timmyc deleted the fix/stats/2534 branch January 18, 2016 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stats: Number format missing from "Latest Post Summary"
3 participants