Autosaves: Create a separate revision when autosaving a draft #26345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jblz
added
[Feature] Post/Page Editor
jblz
force-pushed
the
add/revisions-for-drafts
branch
from
3474adb to
20d02ee
Compare
jblz
added
[Status] Needs Review
spen
approved these changes
Jul 27, 2018
alisterscott
added
[Status] Needs e2e Testing
[Type] Enhancement
|
e2e tests are fine on this one - just expecting the "Import" option which is in master but not this PR |
alisterscott
added
[Status] Ready to Merge
and removed
[Status] Needs Review
jsnajdr
reviewed
Aug 7, 2018
| parent: post.ID, | ||
| status: 'inherit', | ||
| type: 'revision', | ||
| } ); |
There was a problem hiding this comment.
The savePost action dispatches POST_SAVE, POST_SAVE_SUCCESS and POSTS_RECEIVE while saving the post or revision. That updates the structures in state.posts. And the revision doesn't really belong there.
It doesn't immediately break anything, just adds more entropy to already complex and fragile code.
It would be better to directly call wpcom.site().post().add() in the saveRevision action thunk, without the extra dispatches.
jblz
force-pushed
the
add/revisions-for-drafts
branch
from
fe8f2ea to
a7a3020
Compare
|
I'm going to go ahead and close this. To prevent superfluous network requests, we're pursuing a server-side solution in:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #19261, we are passing the
autosaveparam to the API when the Editor saves its buffer. That param results in theDOING_AUTOSAVEconstant getting set &, consequently, revisions are not saved for drafts unless theSavebutton is explicitly clicked.This change conditionally initiates a separate request to save a revision for drafts when they're autosaved.
Fixes #20265
Additionally, this stops showing the autosave
<RestorePostDialog />when relevant fields are identical.To Test
Savebutton to change toSavedHistorybutton should appear when there are revisions & you should see a revision for your edits)