Checklist: rollout to other goal types.

[taggon]

The checklist is currently available only for a blog type site. This PR will roll out it to other goal types so our customers have a more unified experience.

How to test

1. Create a new site with any other type but store.
2. See if the checklist shows up to you.
3. For a non-blog site, "Publish your first blog post" or "You uploaded a profile picture" items should be omitted.

[matticbot]

Test live: https://calypso.live/?branch=signup/rollout-chcklist-to-other-goal-types

[sirreal]

You can leverage getSiteOption like this:

wp-calypso/client/my-sites/stats/checklist-banner/index.jsx

Line 201 in 8eb8c95

const siteDesignType = getSiteOption( state, siteId, [ 'design_type' ] );

[taggon]

I will remove the file in favor of getSiteOption. Thanks. :)

[taggon]

Rebased

[fditrapani]

I tested this with the other options and the checklist shows for me. The copy could use some work but we could leave that for another PR.

[taggon]

Rebased

[fditrapani]

Tested this again and it works as expected. 🎉

[mattwiebe]

I'd love to see some kind of consolidation of checking if the design type supports the checklist rather than the manual checks in several different places, but I don't consider that a blocker.

Otherwise this does what it's supposed to, looks good.

[taggon]

I'd love to see some kind of consolidation of checking if the design type supports the checklist rather than the manual checks in several different places, but I don't consider that a blocker.

I usually do code in that way too. :) But I leave them for now since we're going to roll out the checklist to all users, which means the type checking will be removed in the near future.

Thanks for your review! 👍

[sirreal]

This seems to have introduced the regression #26870 fixed by #26876.

[sirreal]

This seems to have introduced the regression #26911 fixed by #26912