Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CircleCI Node to 10.9.0 #26753

Merged
merged 1 commit into from
Aug 17, 2018
Merged

Update CircleCI Node to 10.9.0 #26753

merged 1 commit into from
Aug 17, 2018

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Aug 17, 2018

Follow up to #26716

Just verify CircleCI tests pass.

@sirreal sirreal added the Build label Aug 17, 2018
@sirreal sirreal self-assigned this Aug 17, 2018
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/circleci-node-10.9

@sirreal sirreal added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 17, 2018
gwwar
gwwar approved these changes Aug 17, 2018
View reviewed changes
Copy link
Contributor

@gwwar gwwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sirreal ! Feel free to land once Desktop tests are ✅

For folks reading, this wasn't updated in the Node upgrade PR, because the image wasn't available before.

@sirreal sirreal added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Aug 17, 2018
@sirreal sirreal merged commit ed40eca into master Aug 17, 2018
@sirreal sirreal deleted the update/circleci-node-10.9 branch August 17, 2018 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwwar gwwar gwwar approved these changes

Assignees

@sirreal sirreal

Labels
Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirreal @matticbot @gwwar