Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: fix box-sizing for icons and drop down menu #27525

Merged
merged 1 commit into from
Oct 1, 2018

Conversation

gwwar
Copy link
Contributor

@gwwar gwwar commented Oct 1, 2018

Changes proposed in this Pull Request

This PR adds missing box-sizing style to fix centering and sizing of buttons.

After
screen shot 2018-10-01 at 2 47 01 pm
screen shot 2018-10-01 at 2 47 07 pm

Before
45851210-956d3280-bcee-11e8-834b-ca2ed54be1b7
screen shot 2018-10-01 at 2 51 51 pm

Testing instructions

  • Checkout this branch
  • visit /gutenberg
  • select a site
  • start typing and look at block options as shown in the images above.
    Expected: we don't see the visual defects shown in the "Before" picture

Fixes #27361

@gwwar gwwar added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Goal] Gutenberg Working towards full integration with Gutenberg labels Oct 1, 2018
@gwwar gwwar self-assigned this Oct 1, 2018
@gwwar gwwar requested a review from a team October 1, 2018 18:53
@matticbot
Copy link
Contributor

@ghost
Copy link

ghost commented Oct 1, 2018

That's a great PR description, thank you so much for your effort!

Generated by 🚫 dangerJS

@westi westi added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 1, 2018
@gwwar gwwar merged commit a51d229 into master Oct 1, 2018
@gwwar gwwar deleted the update/button-styling branch October 1, 2018 21:10
@Copons
Copy link
Contributor

Copons commented Oct 2, 2018

Just wanted to say that, apparently, lots of the glitches we're having with Gutenberg in Calypso are caused by the different box-sizing.
Gutenberg defaults everything to border-box, while Calypso doesn't make such assumption and leaves the freedom to define it as needed.

I've realized it at some point during last week, but I've failed to write about it. It would likely simplify the styling fixes, and I'd love to do a bit of a refactor on the fixes I've already merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gutenberg: style block controls
4 participants