Gutenberg: Apply box-sizing: border-box to the entire section #27928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copons
added
[Status] Needs Review
|
That's a great PR description, thank you so much for your effort! Generated by 🚫 dangerJS |
vindl
reviewed
Oct 18, 2018
| .editor-block-list__block { | ||
| ul ul, ol ol { | ||
| list-style-type: circle; | ||
| z-index: 100000; // Above WP toolbar. |
vindl
reviewed
Oct 18, 2018
| } | ||
| } | ||
| } | ||
|
|
||
| //needed for oembed iframes to appear | ||
| .wp-block-embed__wrapper > iframe { |
There was a problem hiding this comment.
Do we still need this, because box-sizing updates don't seem related?
There was a problem hiding this comment.
I went through the original testing steps too and confirmed that it works as expected even without these styles. 👍Might be the case that package updates made this fix obsolete.
vindl
added
[Status] Ready to Merge
and removed
[Status] Needs Review
This was referenced Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Alt approach to #27914
box-sizing: border-boxto the entire Gutenberg sectionTesting instructions
http://calypso.localhost:3000/gutenberg/post/, and see that most things look good (probably right now only the checkboxes and radio buttons in the sidebar looks wrong).Fixes #27651