Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signup: make user as the first step of the personal flow #28425

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Signup: make user as the first step of the personal flow #28425

merged 1 commit into from
Nov 15, 2018

Conversation

taggon
Copy link
Contributor

@taggon taggon commented Nov 9, 2018

Changes proposed in this Pull Request

  • The user is the first step in the main flow. Therefore, it would make sense to locate it at the first place in other flows such as personal.

Note this should be shipped along with the related e2e updates.

Testing instructions

  • Ensure that you're logged out.
  • Visit /start/personal and check if you are taken to /start/personal/user instead of /start/personal/about.
  • Follow the signup flow.
  • You should be able to complete the process.

@taggon taggon added [Status] In Progress [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. labels Nov 9, 2018
@taggon taggon self-assigned this Nov 9, 2018
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=signup/user-first-personal-flow

@taggon taggon mentioned this pull request Nov 9, 2018
Merged
@taggon taggon added [Status] Needs e2e Testing [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Nov 9, 2018
southp
southp approved these changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@southp southp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM 🚢

@southp southp added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 14, 2018
@taggon taggon merged commit 21c9ea5 into master Nov 15, 2018
@taggon taggon deleted the signup/user-first-personal-flow branch November 15, 2018 11:12
@taggon taggon mentioned this pull request Feb 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@southp southp southp approved these changes

Assignees

@taggon taggon

Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taggon @matticbot @southp