Global Notices: fixed notice__action for global notices #3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fade background was overflowing the round corners and the font-size was incorrect and the padding was off. I also reorganized the notices stylesheet to make more sense.
rickybanister
added
[Status] Needs Review
|
Visuals look good to me. Works as expected. |
alternatekev
removed
the
[Status] Needs Design Review
|
There are some odd paddings in there:
Could these be made to be closer to our grid by changing them to
|
alternatekev
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
|
Aside from the padding values, the code looks good to me too. |
|
The padding values get us to 40px overall height...shrug |
rickybanister
added
[Status] Ready to Merge
and removed
[Status] Needs Author Reply
labels
rickybanister
pushed a commit
that referenced
this pull request
Feb 5, 2016
Global Notices: fixed notice__action for global notices
2 tasks
|
Looks good! |
This was referenced Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fade background was overflowing the round corners and the font-size was incorrect and the padding was off. I also reorganized the notices stylesheet to make more sense.
Closes #3119
cc @mtias @scruffian
Before:
After:
