Components: Consolidate PostSelector styles for standalone usage #3193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Feature] Post/Page Editor
| <a href="/devdocs/app-components/post-selector">Post Selector</a> | ||
| </h2> | ||
| <div style={ { width: 300 } }> | ||
| <PostSelector |
There was a problem hiding this comment.
I like the simplicity of this. Should we clarify which siteId that is from? Should we use your primary site instead?
There was a problem hiding this comment.
Should we use your primary site instead?
Yeah, I like this idea. Updated the example in the rebased 70ef26e2143ccaa5147694cc629c5d6f5df932f4.
aduth
force-pushed
the
update/post-selector-consolidate-styles
branch
from
6d853aa to
70ef26e
Compare
aduth
force-pushed
the
update/post-selector-consolidate-styles
branch
from
70ef26e to
34e340b
Compare
aduth
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
Tests out well, and I like the change to the search box as well. LGTM. |
aduth
added a commit
that referenced
this pull request
Feb 10, 2016
…date-styles Components: Consolidate PostSelector styles for standalone usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for #303
This pull request seeks to migrate many of the styles applied to the
<PostSelector />component in the context of the page editor sidebar to more generalized usage. It also adds the component to the DevDocs App Components page as an example app component.Implementation notes:
These revisions also fix an issue where post titles shown in the selector would appear as encoded, e.g.
Ribs & Chickeninstead ofRibs & Chicken.Design notes:
These revisions also change the search field to be fixed to the top of the non-compact post selector. This is arguably a better user experience, since the search should always be available to the user regardless of search position.
Testing instructions:
Verify that the existing
<PostSelector />used in the Calypso page editor remains unaffected, aside from the single design note described above.Also verify that the DevDocs App Components page includes a functioning example component that displays well as a standalone component.