DevDocs: remove Gutenberg components and blocks #32026
Conversation
vindl
added
[Status] Needs Review
vindl
force-pushed
the
remove/gutenlypso-devdocs
branch
from
8105484 to
1a51094
Compare
| @@ -93,9 +88,7 @@ const Collection = ( { | |||
| component={ component } | |||
| section={ section } | |||
| /> | |||
| { component && ( | |||
| <ReadmeViewer readmeFilePath={ readmeFilePath } showEditLink={ showEditLink } /> | |||
There was a problem hiding this comment.
Note that the showEditLink prop has been added in the same PR that added the whole Gutenberg components in the DevDocs (#26314), and is not used anywhere else.
I guess we could remove it from ReadmeViewer (and its tests) as well.
There was a problem hiding this comment.
I guess we could remove it from ReadmeViewer (and its tests) as well.
Hmm, I still see a couple its usages that are not related to Gutenberg components and blocks: 🤔
https://github.com/Automattic/wp-calypso/search?p=1&q=%22ReadmeViewer%22&unscoped_q=%22ReadmeViewer%22
There was a problem hiding this comment.
Sorry, I meant remove the showEditLink prop from ReadmeViewer (and its tests), not the entire component 🙂
There was a problem hiding this comment.
Oh sorry, it seems I wasn't fully awake while reading your comment. 🤦♂️ That's exactly what you wrote the first time around, but I somehow managed to completely misunderstand it. 😄
Anyway, I'll clean it up in a follow-up.
client/devdocs/style.scss
Outdated
| .main.devdocs.devdocs__gutenberg-components { | ||
| // Make way for showing big components and multiple columns | ||
| max-width: 100%; | ||
| } |
There was a problem hiding this comment.
You've deleted too much stuff here!
We want to keep the max-width: 100% for .devdocs__blocks and .devdocs__components, not only because right now we are giving them the same rules as the next selector, but also because we want the docs to be nice and large! 😛
Jokes aside, you can see that something is especially wrong in the Playground (/devdocs/playground), where the code editor is just too narrow to be usable.
Though, the error is visible in Blocks (/devdocs/blocks) and UI Components (/devdocs/design) as well.
There was a problem hiding this comment.
Ooops! Nice catch! Restored this in 2673416c2f122b1d5e91299d864ea48bf5ad2ed1. :)
vindl
force-pushed
the
remove/gutenlypso-devdocs
branch
from
1a51094 to
6f1fa9e
Compare
|
I've approved this because |
Following the removal of Gutenlypso, it would probably be best to remove these examples to avoid confusion.
vindl
force-pushed
the
remove/gutenlypso-devdocs
branch
from
6f1fa9e to
7f15677
Compare
matticbot
removed
the
[Status] Needs Review
Changes proposed in this Pull Request
Following the removal of Gutenlypso (#31416), it would probably be best to remove these examples to avoid confusion.
See discussion in p7jreA-2g7 (#comment-1869)
Removes the following packages:
@wordpress/block-library@wordpress/date@wordpress/hooksTesting instructions