Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calypso build: Use default babel-loader cacheDirectory #32040

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Calypso build: Use default babel-loader cacheDirectory #32040

merged 1 commit into from
Apr 5, 2019

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Apr 4, 2019

Changes proposed in this Pull Request

Use default babel-loader cache directory.

See docs.

Testing instructions

  1. npx lerna run prepare --scope="*/o2-blocks"
  2. No .cache directory will be created in packages/calypso-build.

@sirreal sirreal added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Packages labels Apr 4, 2019
@sirreal sirreal self-assigned this Apr 4, 2019
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/calypso-build-babel-loader-cache

@sirreal sirreal requested a review from a team April 4, 2019 19:52
ockham
ockham approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jon! 🚀

@sirreal sirreal merged commit 51dbceb into master Apr 5, 2019
@sirreal sirreal deleted the update/calypso-build-babel-loader-cache branch April 5, 2019 05:15
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 5, 2019
@sirreal sirreal mentioned this pull request Apr 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ockham ockham ockham approved these changes

Assignees

@sirreal sirreal

Labels
Packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirreal @matticbot @ockham