-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CircleCI: Build full-site-editing #32431
CircleCI: Build full-site-editing #32431
Conversation
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
7198067
to
1ca19e0
Compare
1ca19e0
to
e5b554a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well for me! I left some optional notes.
apps/full-site-editing/package.json
Outdated
@@ -16,14 +16,15 @@ | |||
}, | |||
"homepage": "https://github.com/Automattic/wp-calypso", | |||
"scripts": { | |||
"php": "cp -R *plugin *theme dist", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for naming this script php
instead of something more related to copying?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reasons, I ran out of good names, and that has been called php
for a long time because of its original intent of only copying php
files.
I'll update it into copy-to-dist
and call it a day.
ln -s ~/Dev/wp-calypso/apps/full-site-editing/full-site-editing-plugin/ ~/Dev/wordpress/wp-content/plugins/full-site-editing-plugin | ||
|
||
ln -s ~/Dev/wp-calypso/apps/full-site-editing/blank-theme/ ~/Dev/wordpress/wp-content/themes/blank-theme | ||
/dist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that might be the dist
folder created by the previous build system, which gets copied into the new dist
.
Try deleting all three dist
folders and rebuild: that shouldn't be there anymore. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was suspecting I was doing something wrong and tried deleting them and rebuilding (seemed to be coming back). Anyway, probably an error on my end so feel free to proceed. :)
Changes proposed in this Pull Request
dist
folder containing plugin and theme.Testing instructions
build-full-site-editing
job.npx lerna run dev --scope='@automattic/full-site-editing'
npx lerna run build --scope='@automattic/full-site-editing'
Fix #32488 (see also D27231-code)