Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI: Build full-site-editing #32431

Merged
merged 2 commits into from
Apr 24, 2019

Conversation

Copons
Copy link
Contributor

@Copons Copons commented Apr 19, 2019

Changes proposed in this Pull Request

  • Add a CircleCI job that creates artifacts from the dist folder containing plugin and theme.
  • Update the whole build system of the app (check the updated readme).

Testing instructions

  • On CircleCI, check the artifacts contained in the build-full-site-editing job.
  • Make sure they contain all the built files and the source and PHP files as well.
  • Locally, run the following scripts, and make sure they work as expected.
    • npx lerna run dev --scope='@automattic/full-site-editing'
    • npx lerna run build --scope='@automattic/full-site-editing'
  • Don't forget to update the symlinks to the dist (check the updated readme) if needed!

Fix #32488 (see also D27231-code)

@Copons Copons requested a review from a team as a code owner April 19, 2019 11:55
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@Copons Copons requested a review from a team April 19, 2019 18:23
@Copons Copons self-assigned this Apr 19, 2019
@Copons Copons added [Goal] Full Site Editing [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 19, 2019
@Copons Copons force-pushed the update/32419-full-site-editing-circle-ci-workflow branch from 7198067 to 1ca19e0 Compare April 22, 2019 09:57
@Copons Copons force-pushed the update/32419-full-site-editing-circle-ci-workflow branch from 1ca19e0 to e5b554a Compare April 23, 2019 11:17
Copy link
Member

@vindl vindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well for me! :shipit: I left some optional notes.

@@ -16,14 +16,15 @@
},
"homepage": "https://github.com/Automattic/wp-calypso",
"scripts": {
"php": "cp -R *plugin *theme dist",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for naming this script php instead of something more related to copying?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reasons, I ran out of good names, and that has been called php for a long time because of its original intent of only copying php files.
I'll update it into copy-to-dist and call it a day.

ln -s ~/Dev/wp-calypso/apps/full-site-editing/full-site-editing-plugin/ ~/Dev/wordpress/wp-content/plugins/full-site-editing-plugin

ln -s ~/Dev/wp-calypso/apps/full-site-editing/blank-theme/ ~/Dev/wordpress/wp-content/themes/blank-theme
/dist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to this one, it seems to be also creating another dist subfolder in full-site-editing-plugin. Is that intended? (asking because it was confusing for me at first)

Screenshot 2019-04-23 at 17 47 25

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that might be the dist folder created by the previous build system, which gets copied into the new dist.
Try deleting all three dist folders and rebuild: that shouldn't be there anymore. 🙂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was suspecting I was doing something wrong and tried deleting them and rebuilding (seemed to be coming back). Anyway, probably an error on my end so feel free to proceed. :)

@vindl vindl added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 23, 2019
@Copons Copons merged commit 4f6bb1f into master Apr 24, 2019
@Copons Copons deleted the update/32419-full-site-editing-circle-ci-workflow branch April 24, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full Site Editing: Calypso support for plugin development flows [1]
3 participants