-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency moment-timezone to v0.5.26 #34501
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~30134 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~15076 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates the TZ data to the latest version. @sgomes will like the dramatic bundle size decrease 🙂
@jsnajdr I do indeed! Woohoo, 3.7KB gone! :D That's probably the first time I've seen a timezone update bring the numbers down. Which makes me very suspicious, of course. Especially with a patch release... |
@jsnajdr They switched from I suspect we'll see a new |
@jsnajdr Some more evidence towards something being wrong here: moment/moment-timezone#768 I'd recommend rolling back, out of an abundance of caution. |
@sgomes I did some research into this, summarized in moment/moment-timezone#768 (comment) TLDR:
Let's continue watching the issue, but I think that revert is not needed at this moment. |
Sounds good, thank you for the thorough investigation, @jsnajdr ! 👍 |
This PR contains the following updates:
0.5.25
->0.5.26
Release Notes
moment/moment-timezone
v0.5.26
Compare Source
2019b
Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "
rebase!
".🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot. View repository job log here.