Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency moment-timezone to v0.5.26 #34501

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 6, 2019

This PR contains the following updates:

Package Type Update Change
moment-timezone (source) dependencies patch 0.5.25 -> 0.5.26

Release Notes

moment/moment-timezone

v0.5.26

Compare Source

  • Updated data to IANA TZDB 2019b
  • Fix: stabilize Array.sort #​762

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner July 6, 2019 15:17
@renovate renovate bot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Task Framework labels Jul 6, 2019
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~30134 bytes removed 📉 [gzipped])

name              parsed_size            gzip_size
stats               -353312 B  (-32.6%)    -3761 B  (-2.0%)
settings-writing    -353312 B  (-43.1%)    -3768 B  (-3.2%)
settings            -353312 B  (-37.7%)    -3767 B  (-2.5%)
post-editor         -353312 B  (-16.0%)    -3770 B  (-0.7%)
help                -353312 B  (-39.4%)    -3767 B  (-2.7%)
concierge           -353312 B  (-58.3%)    -3768 B  (-5.8%)
comments            -353312 B  (-40.4%)    -3767 B  (-3.0%)
activity            -353312 B  (-46.6%)    -3766 B  (-3.6%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~15076 bytes removed 📉 [gzipped])

name                                   parsed_size            gzip_size
async-load-signup-steps-clone-point      -353312 B  (-68.3%)    -3769 B  (-9.0%)
async-load-design-blocks                 -353312 B  (-11.9%)    -3770 B  (-0.6%)
async-load-blocks-inline-help-popover    -353312 B  (-53.6%)    -3770 B  (-4.8%)
async-load-blocks-calendar-popover       -353312 B  (-60.0%)    -3767 B  (-7.5%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@Automattic Automattic deleted a comment from matticbot Jul 8, 2019
Copy link
Member

@jsnajdr jsnajdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates the TZ data to the latest version. @sgomes will like the dramatic bundle size decrease 🙂

@jsnajdr jsnajdr merged commit b074a20 into master Jul 8, 2019
@jsnajdr jsnajdr deleted the renovate/moment-timezone-0.x branch July 8, 2019 09:59
@sgomes
Copy link
Contributor

sgomes commented Jul 8, 2019

@jsnajdr I do indeed! Woohoo, 3.7KB gone! :D That's probably the first time I've seen a timezone update bring the numbers down.

Which makes me very suspicious, of course. Especially with a patch release...
I'm not about to go audit timezone data, though, so let's just assume whatever data source they changed to just has less redundancy while maintaining correctness.

@sgomes
Copy link
Contributor

sgomes commented Jul 8, 2019

@jsnajdr They switched from tzdb-2019a to tzdb-2019b. Going to the IANA website, tzdb-2019b appears to be larger, as I would expect from a timezone update.

I suspect we'll see a new moment-timezone soon, reinstating some missing data.

@sgomes
Copy link
Contributor

sgomes commented Jul 8, 2019

@jsnajdr Some more evidence towards something being wrong here: moment/moment-timezone#768

I'd recommend rolling back, out of an abundance of caution.

@jsnajdr
Copy link
Member

jsnajdr commented Jul 8, 2019

@sgomes I did some research into this, summarized in moment/moment-timezone#768 (comment)

TLDR:

  • there is probably a real bug, but seems to affect only periods before 1910 and after 2037
  • the smaller size of the packed data is expected

Let's continue watching the issue, but I think that revert is not needed at this moment.

@sgomes
Copy link
Contributor

sgomes commented Jul 8, 2019

Sounds good, thank you for the thorough investigation, @jsnajdr ! 👍

@jsnajdr jsnajdr mentioned this pull request Jan 19, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants