Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE: Remove template block settings and UI #35115

Merged
merged 6 commits into from
Aug 5, 2019
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ registerBlockType( 'a8c/post-content', {
icon: 'layout',
category: 'layout',
supports: {
anchor: true,
anchor: false,
customClassName: false,
html: false,
multiple: false,
reusable: false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,31 +37,29 @@
/* Hide the content slot block UI */
.block-editor-block-list__layout {
.post-content__block {
> .block-editor-block-list__block-edit {
&::before {
transition: none;
}

> .block-editor-block-list__breadcrumb {
display: none;
}
}

&.is-selected {
> .block-editor-block-list__block-edit::before {
border: none;
box-shadow: none;
}

.block-editor-block-contextual-toolbar {
display: none;
}
}

&.is-hovered {
> .block-editor-block-list__block-edit::before {
border: none;
box-shadow: none;
&.block-editor-block-list__block {
// Need to get super specific to override the core css selectors:
&,
&.has-child-selected,
&.is-navigate-mode,
&.is-hovered {
> .block-editor-block-list__block-edit {
&::before {
transition: none;
border: none;
outline: none;
box-shadow: none;
}
> .block-editor-block-list__breadcrumb {
display: none;
}
}
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
*/
import { registerBlockType } from '@wordpress/blocks';
import { __ } from '@wordpress/i18n';
import { createHigherOrderComponent } from '@wordpress/compose';
import { addFilter } from '@wordpress/hooks';

/**
* Internal dependencies
Expand All @@ -19,7 +21,8 @@ if ( 'wp_template' !== fullSiteEditing.editorPostType ) {
category: 'layout',
attributes: { templateId: { type: 'number' } },
supports: {
anchor: true,
anchor: false,
customClassName: true, // Needed to support the classname we inject
html: false,
reusable: false,
},
Expand All @@ -30,3 +33,15 @@ if ( 'wp_template' !== fullSiteEditing.editorPostType ) {
},
} );
}

const addFSETemplateClassname = createHigherOrderComponent( BlockListBlock => {
return props => {
if ( props.name !== 'a8c/template' ) {
return <BlockListBlock { ...props } />;
}

return <BlockListBlock { ...props } className="template__block-container" />;
};
}, 'addFSETemplateClassname' );

addFilter( 'editor.BlockListBlock', 'full-site-editing/blocks/template', addFSETemplateClassname );
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,34 @@
color: white;
}
}

/* Hide the content slot block UI */
.block-editor-block-list__layout {
.template__block-container {
&.is-selected {
.block-editor-block-contextual-toolbar {
display: none;
}
}

&.block-editor-block-list__block {
// Need to get super specific to override the core css selectors:
&,
&.has-child-selected,
&.is-navigate-mode,
&.is-hovered {
> .block-editor-block-list__block-edit {
&::before {
transition: none;
border: none;
outline: none;
box-shadow: none;
}
> .block-editor-block-list__breadcrumb {
display: none;
}
}
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
/* global fullSiteEditing */

/**
* External dependencies
*/
import { select, dispatch, subscribe } from '@wordpress/data';
import { get } from 'lodash';

/**
* Removes the block settings panel if the template or post content blocks are selected.
* Since it is not possible to disable the block settings entirely through Gutenberg state,
* we use a hack to deselect the block, which removes the option to change its settings.
* This is also done officially in the core PostTitle block, so there is prior art.
*
* @see https://github.com/WordPress/gutenberg/blob/master/packages/editor/src/components/post-title/index.js
*/
const unsubscribe = subscribe( () => {
// We don't care about this on the template or post editor
if ( 'page' !== fullSiteEditing.editorPostType ) {
return unsubscribe();
}

// Determine which block we have selected:
const selectedBlock = select( 'core/editor' ).getSelectedBlock();
const blockName = get( selectedBlock, 'name', null );

// If we have selected one the template block, deselect it.
// Note: this does not work for post content because you can't
// edit inner blocks if the block is not selected.
if ( 'a8c/template' === blockName ) {
dispatch( 'core/block-editor' ).clearSelectedBlock( blockName );
}
} );
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@
import './block-inserter';
import './template-validity-override';
import './image-block-keywords';
import './disable-block-settings';
import './style.scss';