Reader: Add the subscription count to all reader track events, if available #3517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blowery
added
[Status] Needs Review
blowery
force-pushed
the
add/subs-count-reader-tracks
branch
from
11a7f24 to
eea15a8
Compare
| @@ -77,5 +79,9 @@ export function recordUnfollow( url ) { | |||
| } | |||
|
|
|||
| export function recordTrack( eventName, eventProperties ) { | |||
| const subCount = SubscriptionStore.getTotalSubscriptions(); | |||
There was a problem hiding this comment.
One potential risk is that, in #3418, we switch to incrementing totalSubscriptions in the store and no longer use the subscription count from the first page of the response. This count mean that getTotalSubscriptions() reports 50, 100, 150.... as the subs get loaded in.
There was a problem hiding this comment.
Hmmmm. We probably need to keep around the total number of subs. Sounds like we'll need to mod #3418.
There was a problem hiding this comment.
think we can land this and fixup #3418?
There was a problem hiding this comment.
👍 I've added a note to #3418.
|
🚢 |
bluefuton
added
[Status] Ready to Merge
and removed
[Status] Needs Review
bluefuton
added a commit
that referenced
this pull request
Feb 24, 2016
Reader: Add the subscription count to all reader track events, if available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help us determine how many subscriptions an active user has.