SPT: Fetch Assets for blocks #35588
Merged
SPT: Fetch Assets for blocks #35588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marekhrabe
added
the
[Status] Needs Review
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
obenland
approved these changes
Aug 19, 2019
obenland
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This adds a utility function that receives blocks, automatically looks for images in them, fetches them (if there are any) and returns the same blocks with assets updated to use the local ones.
This PR is split from #34839 — it's a piece of code that could be merged separately first to keep the integration PR easier to rebase and review.
Testing instructions
This PR only includes the functions, not how they are called. You can test the functionality in #34839. The file
ensure-assets.jsis copied verbatim from that PR.