Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenboarding: Update Template Selector Styling #38403

Closed
wants to merge 13 commits into from

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Dec 13, 2019

Changes proposed in this Pull Request

WIP.

  • Centered 960px
  • 2 columns
  • No template captions
  • High-res thumbnails
  • Enable scrolling
  • Heading
  • Keep verticalized background from intent gathering step

Mockup

Design picker

Current Status

image

Testing instructions

http://calypso.localhost:3000/gutenboarding

Fill in verticals and site title, click next.

@ockham ockham added [Status] In Progress [Goal] Gutenberg Working towards full integration with Gutenberg [Feature Group] Signup & Site Onboarding Tools for user registration and onboarding new users to the site. labels Dec 13, 2019
@ockham ockham self-assigned this Dec 13, 2019
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Dec 13, 2019

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~3 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
entry-gutenboarding       +221 B  (+0.0%)       +3 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@ockham ockham force-pushed the update/gutenboarding-template-selector-styling branch from 0c170b6 to 80c9294 Compare December 13, 2019 15:22
@simison
Copy link
Member

simison commented Dec 15, 2019

No template captions

I saw some back-forth discussion about this actually another day on Slack — let's double check on Monday. Easy enough to them back after the fact anyway.

@ockham ockham force-pushed the update/gutenboarding-template-selector-styling branch from 26340c2 to 0dabd9c Compare December 16, 2019 06:30
@ockham
Copy link
Contributor Author

ockham commented Dec 17, 2019

Closing in favor of #38456.

@ockham ockham closed this Dec 17, 2019
@ockham ockham deleted the update/gutenboarding-template-selector-styling branch December 17, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Signup & Site Onboarding Tools for user registration and onboarding new users to the site. [Goal] Gutenberg Working towards full integration with Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants