-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a page navigation dropdown to gutenberg #39826
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~3 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~3439 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
I tried testing this locally but I can't spot the Page navigation dropdown in the header. Is there anything that I might be missing in terms of testing instructions? |
Maybe some of the newer Gutenberg updates are changing the format of the top bar? |
oh, folks, sorry for the lack of instructions, I wasn't thinking anyone would try to test this yet!! I'll add some better description today or tomorrow |
I don't think that would necessarily affect the display since it looks like this should be rendered on top of the iframe. At worst new updates would cause it to be slightly misplaced imo. 🤔 |
@johnHackworth Can this be closed? |
This PR has been marked as stale due to lack of activity within the last 30 days. |
Closing, since we have the page navigation sidebar now |
WORK IN PROGRESS:
This PR adds a page navigation dropdown in top of the block editor top bar when the user is editing one of their site's pages