Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a page navigation dropdown to gutenberg #39826

Closed
wants to merge 1 commit into from

Conversation

johnHackworth
Copy link
Contributor

WORK IN PROGRESS:

This PR adds a page navigation dropdown in top of the block editor top bar when the user is editing one of their site's pages

@johnHackworth johnHackworth requested review from a team as code owners March 3, 2020 10:00
@matticbot
Copy link
Contributor

@johnHackworth johnHackworth added [Goal] Gutenberg Working towards full integration with Gutenberg [Goal] New Onboarding previously called Gutenboarding [Status] In Progress labels Mar 3, 2020
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~3 bytes removed 📉 [gzipped])

name                 parsed_size           gzip_size
entry-gutenboarding        -27 B  (-0.0%)       -3 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~3439 bytes added 📈 [gzipped])

name              parsed_size           gzip_size
gutenberg-editor     +12107 B  (+1.4%)    +3439 B  (+1.5%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@vindl
Copy link
Member

vindl commented Mar 4, 2020

I tried testing this locally but I can't spot the Page navigation dropdown in the header. Is there anything that I might be missing in terms of testing instructions?

@noahtallen
Copy link
Contributor

Is there anything that I might be missing in terms of testing instructions

Maybe some of the newer Gutenberg updates are changing the format of the top bar?

@johnHackworth
Copy link
Contributor Author

oh, folks, sorry for the lack of instructions, I wasn't thinking anyone would try to test this yet!! I'll add some better description today or tomorrow

@vindl
Copy link
Member

vindl commented Mar 5, 2020

Maybe some of the newer Gutenberg updates are changing the format of the top bar?

I don't think that would necessarily affect the display since it looks like this should be rendered on top of the iframe. At worst new updates would cause it to be slightly misplaced imo. 🤔

@sarayourfriend sarayourfriend changed the base branch from master to trunk November 20, 2020 16:13
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 20, 2020
@sirreal
Copy link
Member

sirreal commented Dec 4, 2020

@johnHackworth Can this be closed?

@github-actions
Copy link

github-actions bot commented May 5, 2021

This PR has been marked as stale due to lack of activity within the last 30 days.

@noahtallen
Copy link
Contributor

Closing, since we have the page navigation sidebar now

@noahtallen noahtallen closed this May 5, 2021
@worldomonation worldomonation deleted the new/page-navigation-in-gutenberg branch September 27, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Goal] New Onboarding previously called Gutenboarding [Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants