Reader: Update the post time more frequently #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior, we updated the time every 60s, which doesn't work well for posts that are very recent. This drops the update time to 10s. In addition, we moved to only setting the state if it has changed, to avoid unnecessary rerenders.
blowery
added
[Status] Needs Review
| _update: function( date ) { | ||
| date = date || this.props.date; | ||
| this.setState( { ago: humanDate( date ) } ); | ||
| this.smartSetState( { ago: humanDate( date ) } ); |
There was a problem hiding this comment.
Do we need to avoid setting the state if we have PureRenderMixin? It works on state, too.
There was a problem hiding this comment.
Apart from that looks/works great, you can 
There was a problem hiding this comment.
so, PRM doesn't prevent the all the work that happens just to get to shouldComponentUpdate. setting state enqueues work for the component, whether the new state is different or not. This avoids that work when we don't need to do it.
nb
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
blowery
added a commit
that referenced
this pull request
Dec 2, 2015
…uently Reader: Update the post time more frequently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior, we updated the time every 60s, which doesn't work well for posts that are very recent. This drops the update time to 10s.
In addition, we moved to only setting the state if it has changed, to avoid unnecessary rerenders.