Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Premium Content Block: disable "Edit as HTML" option #42498

Merged
merged 1 commit into from
May 20, 2020
Merged

Premium Content Block: disable "Edit as HTML" option #42498

merged 1 commit into from
May 20, 2020

Conversation

n3f
Copy link
Contributor

@n3f n3f commented May 20, 2020 •
edited
Loading

Changes proposed in this Pull Request

  • Remove the "Edit as HTML" options for the inner blocks of the Premium Content Block.

Testing instructions

  • Start up the FSE environment and create a premium content block.
  • Under the "Non-subscriber View", click the Subscribe button.
  • Click the kabob menu (i.e. More options/horizontal dots/ellipses) and verify that the "Edit as HTML" option has been removed.

Fixes #41834

@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=earn/pcb-disable-edit-as-html

@n3f n3f added the Earn label May 20, 2020
@n3f n3f requested a review from a team May 20, 2020 19:39
@n3f n3f added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 20, 2020
@matticbot
Copy link
Contributor

Caution: This PR affects files in the FSE Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D43735-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing in the FSE Plugin for more info: PCYsg-ly5-p2

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@beaucollins beaucollins self-requested a review May 20, 2020 21:00
beaucollins
beaucollins approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@beaucollins beaucollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both buttons in the "Non-subscriber View" show render the menu correctly:

image

@beaucollins beaucollins added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 20, 2020
@n3f n3f merged commit d7ef998 into master May 20, 2020
@n3f n3f deleted the earn/pcb-disable-edit-as-html branch May 20, 2020 21:35
@ockham ockham mentioned this pull request May 29, 2020
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beaucollins beaucollins beaucollins approved these changes

Assignees
No one assigned
Labels
Earn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Premium Content Block: disable "Edit as HTML" option
3 participants
@n3f @matticbot @beaucollins