Add a small Calypso banner on top of the HTML #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nb
added
Documentation
[Status] Needs Review
|
Hm, breaks some i18n tests, looks like related to the |
nb
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
|
Would be nice to have visual record — what does it look like? |
Props @stephanethomas who used it in `calypso-bootstrap`. Generated by `figlet -c -w 40 "calypso”`.
nb
force-pushed
the
add/html-source-banner
branch
from
e6fef23 to
60dfa0e
Compare
|
Also, I had upgraded |
nb
added
[Status] Needs Review
|
Looks good in desktop browsers except Safari — for some reason it gets mangled. This is using the iOS simulator, then viewing source:
I don't think that's a blocker, though. 🚢 |
lancewillett
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
@lancewillett, click on “Resources” (or Develop → View Page Source). In “Elements” the goal is not to show the source, but some structured interpretation. |
nb
added a commit
that referenced
this pull request
Nov 22, 2015
Add a small Calypso banner on top of the HTML
|
Cool: in desktop Safari it looks fine.
|
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for knowing which page is Calypso and just for fun.
Props @stephanethomas who used it in
calypso-bootstrap.Generated by
figlet -c -w 40 "calypso”.Had to upgrade
jade, otherwise parsing of the comment failed.