-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader: ensure button block matches main site styles #43779
Reader: ensure button block matches main site styles #43779
Conversation
@leandroalonso Here's what I have so far. Do you have thoughts on what styling you want brought over? I'm told reader is opinionated on colours, so I haven't brought those over. |
8ec60b5
to
30d98fd
Compare
Hi @tophertoy! Thanks for your contribution! @bluefuton would you mind reviewing this one? |
Thanks for the contribution @tophertoy! Can we match the styles applied to the default Calypso button? https://wordpress.com/devdocs/packages/components/src/button/README.md?term=button I think the 'non-primary' version would make the most sense. It looks like this: |
@bluefuton that link appears not to be working for me. Also https://wordpress.com/devdocs/ is 404ing. Do you want me to work from the attached "Bananas" image? |
Sorry @tophertoy - try on wpcalypso: https://wpcalypso.wordpress.com/devdocs/packages/components/src/button/README.md?term=button |
30d98fd
to
f8bf89f
Compare
@bluefuton ok I've made some changes. Attached screenshots from firefox and chrome at the top. Let me know what you think or if there is a defined browser list I should check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far - just a couple of tweaks to bring it in line with the Button component.
@bluefuton I've made those changes. |
Co-authored-by: Chris R <chris@bluefuton.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚢
Changes proposed in this Pull Request
This change handles styling the button block in reader to match the website It is only part 1 of 8 of this issue:
#43595
Testing instructions
Before:
Taken from: http://calypso.localhost:3000/read/blogs/159889361/posts/1363
Firefox After: