Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor Toolkit: update slide copy in NUX #46674

Merged
merged 3 commits into from
Nov 6, 2020
Merged

Editor Toolkit: update slide copy in NUX #46674

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24b107f
Updating copy to emphasis the hidden nature of Coming Soon, but not t…
ramonjd Oct 22, 2020
fde7cb5
Update wpcom-nux.js
ramonjd Oct 28, 2020
5f7dda4
Update wpcom-nux.js
ramonjd Oct 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions apps/editing-toolkit/editing-toolkit-plugin/wpcom-block-editor-nux/src/wpcom-nux.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,11 @@ function WpcomNux() {
}

/**
* This function returns a filtered collection of NUX slide data
* Function arguments can be extended to customize the slides for specific environments, e.g., Gutenboarding
* This function returns a collection of NUX slide data
*
* @param { boolean } isGutenboarding Whether the flow is Gutenboarding or not
* @returns { Array } a collection of <NuxPage /> props filtered by whether the flow is Gutenboarding or not
* @returns { Array } a collection of <NuxPage /> props
*/
function getWpcomNuxPages( isGutenboarding ) {
function getWpcomNuxPages() {
return [
{
heading: __( 'Welcome to your website', 'full-site-editing' ),
Expand Down Expand Up @@ -108,17 +106,15 @@ function getWpcomNuxPages( isGutenboarding ) {
alignBottom: true,
},
{
heading: __( 'Private until you’re ready', 'full-site-editing' ),
heading: __( 'Hidden until you’re ready', 'full-site-editing' ),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This change will be queued for retranslation. We'll display the English text until then.

description: __(
'Your site will remain private as you make changes until you’re ready to launch and share with the world.',
'Your site will remain hidden until launched. Click “Launch” in the toolbar to share it with the world.',
'full-site-editing'
),
imgSrc: privateImage,
// @TODO: hide for sites that are already public
shouldHide: ! isGutenboarding,
Comment on lines -117 to -118
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically thie @TODO hasn't been addressed, but I don't know who's responsibility it is or even when this modal would appear for a public site so 🤷

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My inclination is to let the reference to "hidden" slide for now. The main reason we're showing this one for all users I think stems from p9Jlb4-1SN-p2

The intention the button will now be displayed to users regardless of their path into WordPress and will be combined with the Focused launch flow work currently in development by Team Luna.

Copy link

@razvanpapadopol razvanpapadopol Nov 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave the @T0D0 or create an issue for this because from what I understand it is referring to the launched/un-launched status of a website and not to the onboarding (site creation) flow. So here is an example where we probably don't want the slide to be displayed:

  1. User created a site and landed in My Home or Plans (after abandoning cart).
  2. User launched the site via Site setup checklist in My Home without opening the editor.
  3. User navigates to the editor and the Launch button in the toolbar is gone since the site is already launched.

alignBottom: true,
},
].filter( ( nuxPage ) => ! nuxPage.shouldHide );
];
}

function NuxPage( { alignBottom = false, heading, description, imgSrc } ) {
Expand Down