-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editing Toolkit: Update to 2.8.4 #47186
Conversation
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D52369-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
6a33f77
to
e176384
Compare
It looks like the text in the last slide of the editor welcome modal is not translated correctly: See p1604665886075900-slack-C014TPFLP for more details. We should:
|
e176384
to
e0a50b2
Compare
Verified: |
D52369-code deployed, The failing |
Changes proposed in this Pull Request
Changes to Editing Toolkit since 2.8.3:
Testing instructions
Load the diff on your sandbox D52369-code and confirm that the above changes work correctly
Test that the new version of the plugin doesn't break Atomic sites by following the instructions in the "Atomic Testing" section at PCYsg-ly5-p2.