Coming Soon: Set the headers to prevent caching for the different browsers. #47450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the html and char types from bloginfo
ramonjd
added
[Status] Needs Review
|
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D52779-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
The content-type html header is already set, so doesn't need to be set again here.
|
We don't need to explicitly set the content-type header, it already gets set for us. Also the failing php tests are unrelated to this change, the tracking issue is #47255 |
p-jackson
approved these changes
Nov 16, 2020
matticbot
removed
the
[Status] Needs Review
8 tasks
Thanks for handling this one @p-jackson ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Let's make sure we don't allow caching for the Coming Soon pages.
We'll also set the html and char types from bloginfoTesting instructions
Create a coming soon v2 site over at wordpress.com/new?flags=coming-soon-v2
I used Firefox, which seems to have a fairly aggressive caching approach.
With your new site in coming soon mode, open it in Firefox (logged out) and take a look at the network tab in the console for the HTML page.
Now run
yarn dev --syncon this branch, and sandbox your new site.Refresh and make sure you can see expiry headers (in the past so as to invalidate the cache)