-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply LocaleProvider to calypso #47692
Conversation
Co-authored-by: Philip Jackson <p-jackson@live.com>
Didn't seem to fix it either, must be something wrong with this PR, maybe package.json changes got clobbered somehow? |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~469 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~10 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~20 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Figured out why the build was broken in #47613 so can delete this PR which was just a re-attempt at the same code changes in a different PR. |
Changes proposed in this Pull Request
Testing instructions
Fixes #45610 🎉