Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply LocaleProvider to calypso #47692

Closed
wants to merge 6 commits into from
Closed

Apply LocaleProvider to calypso #47692

wants to merge 6 commits into from

Conversation

lsl
Copy link
Contributor

@lsl lsl commented Nov 24, 2020

Changes proposed in this Pull Request

  • Implements usage of LocaleProvider, useLocalizeUrl
  • Implements withLocalizeUrl
  • Makes use of both with/useLocalizeUrl
  • adds i18n-utils to domain-picker package

Testing instructions

Fixes #45610 🎉

@lsl lsl added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 24, 2020
@matticbot
Copy link
Contributor

@lsl lsl requested a review from p-jackson November 24, 2020 04:22
@lsl
Copy link
Contributor Author

lsl commented Nov 24, 2020

Didn't seem to fix it either, must be something wrong with this PR, maybe package.json changes got clobbered somehow?

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~469 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                  +796 B  (+0.1%)     +113 B  (+0.0%)
entry-gutenboarding         +717 B  (+0.0%)     +144 B  (+0.0%)
entry-login                 +647 B  (+0.1%)      +88 B  (+0.0%)
entry-domains-landing       +647 B  (+0.1%)     +124 B  (+0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~10 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
privacy        +14 B  (+0.0%)      +10 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~20 bytes added 📈 [gzipped])

name                                           parsed_size           gzip_size
async-load-calypso-blocks-editor-launch-modal        +70 B  (+0.0%)      +20 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@p-jackson
Copy link
Member

Figured out why the build was broken in #47613 so can delete this PR which was just a re-attempt at the same code changes in a different PR.

@p-jackson p-jackson closed this Nov 30, 2020
@p-jackson p-jackson deleted the update/use-locale-2 branch November 30, 2020 02:54
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localize Support URL for HSTS Tooltip in Domain Picker
4 participants