Add basic GB upgrade (regression) tests for the Premium Content block #47723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fullofcaffeine
force-pushed
the
add/gb-upgrade-test-for-premium-block
branch
from
56e7c30 to
5ccbfd7
Compare
fullofcaffeine
added
the
[Status] Needs e2e Testing Gutenberg Edge
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
fullofcaffeine
added
[Status] Needs e2e Testing Gutenberg Edge
fullofcaffeine
force-pushed
the
add/gb-upgrade-test-for-premium-block
branch
from
5ccbfd7 to
9176f2c
Compare
fullofcaffeine
added
[Status] Needs e2e Testing
and removed
[Status] Needs e2e Testing Gutenberg Edge
fullofcaffeine
force-pushed
the
add/gb-upgrade-test-for-premium-block
branch
from
9176f2c to
1b184c6
Compare
fullofcaffeine
added
[Status] Needs e2e Testing Gutenberg Edge
fullofcaffeine
force-pushed
the
add/gb-upgrade-test-for-premium-block
branch
from
1b184c6 to
5867c77
Compare
WunderBart
requested changes
Nov 26, 2020
1 task
fullofcaffeine
force-pushed
the
add/gb-upgrade-test-for-premium-block
branch
from
5867c77 to
94d851c
Compare
fullofcaffeine
added
[Status] Needs Review
fullofcaffeine
added
[Status] Needs e2e Testing Gutenberg Edge
fullofcaffeine
force-pushed
the
add/gb-upgrade-test-for-premium-block
branch
from
4414549 to
df2a449
Compare
fullofcaffeine
added
[Status] Needs e2e Testing Gutenberg Edge
fullofcaffeine
force-pushed
the
add/gb-upgrade-test-for-premium-block
branch
from
df2a449 to
5023cfc
Compare
fullofcaffeine
added
[Status] Needs e2e Testing Gutenberg Edge
fullofcaffeine
force-pushed
the
add/gb-upgrade-test-for-premium-block
branch
from
5023cfc to
94e3ea5
Compare
WunderBart
added
[Status] Ready to Merge
and removed
[Status] Needs Review
fullofcaffeine
added
[Status] Needs e2e Testing
and removed
[Status] Needs e2e Testing Gutenberg Edge
fullofcaffeine
force-pushed
the
add/gb-upgrade-test-for-premium-block
branch
from
94e3ea5 to
9297b48
Compare
fullofcaffeine
added
[Status] Needs e2e Testing
and removed
[Status] Needs e2e Testing
labels
- Make sure it doesn't error in the editor and that it renders in the frontend; - Make sure it works well after upgrade to GB edge.
fullofcaffeine
force-pushed
the
add/gb-upgrade-test-for-premium-block
branch
from
9297b48 to
c0e1092
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Add basic GB upgrade tests for the Premium Content block:
This aims at preventing the regression of issues like #47467 in the future.
Testing instructions
[Status] Needs e2e Testing Gutenberg Edgelabel is applied to this PR. If you want to restart tests, remove and apply it again. All Github checks in the PR should be green 🟢Observations
This branches off this PR (since it hasn't been merged yet). The specific GB 9.4.1 fixes there are needed because we are currently running 9.4.1 on edge sites. Upgrade tests need to run on edge sites too.
Stripe connection
This required me to setup a Stripe connection for the Premium Content block for all the sites under the
gutenbergUpgradeUser(see yourlocal-decrypted.json) WPCOM account. Stripe test account info was kindly handed to me by @apeatling.Closes: #47552