Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Picker: re-enable Reynolds design #49608

Merged
merged 1 commit into from
May 11, 2021

Conversation

simison
Copy link
Member

@simison simison commented Feb 2, 2021

Changes proposed in this Pull Request

Testing instructions

  • Open /new
  • Proceed to design
  • Observe design

Here's a direct test link that's easier, no need to open live-branch for testing:

https://public-api.wordpress.com/rest/v1/template/demo/rockfield/reynolds/?language=en&site_title=&font_headings=Playfair%20Display&font_base=Fira%20Sans

Depends on:

FYI @ianstewart — this PR allows easy testing of Reynolds design while it's disabled:

https://calypso.live/new/design?branch=update/re-enable-reynolds-design

@simison simison added [Status] Blocked / Hold [Goal] New Onboarding previously called Gutenboarding labels Feb 2, 2021
@matticbot
Copy link
Contributor

matticbot commented Feb 2, 2021

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@ianstewart
Copy link
Contributor

ianstewart commented Feb 2, 2021

Depends on https://href.li/?https://github.com/Automattic/block-experiments/pull/161 merged and deployed first.

There's still global styles / themes issues present as well.

Font-preview screen …

image

Front-end preview in Editor …

image

Front-end …

image

@ianstewart
Copy link
Contributor

Related issue Automattic/themes#2971

@simison
Copy link
Member Author

simison commented Feb 8, 2021

Depends on Automattic/themes#3197

@simison
Copy link
Member Author

simison commented Feb 10, 2021

@ianstewart @scruffian 👋 I think all the known theme side issues got sorted for this to work but small things remain:

Screen.Recording.2021-02-10.at.18.46.36.mov

Those could be issues in templates, and adjusting some button colors might help?

@scruffian
Copy link
Member

Related Gutenberg issue: WordPress/gutenberg#27075

@simison
Copy link
Member Author

simison commented Mar 24, 2021

@ianstewart buttons are looking good in the preview at least — what do you think about re-releasing this design in the grid?

@simison simison force-pushed the update/re-enable-reynolds-design branch from 654fdb2 to 21fdb67 Compare March 24, 2021 09:11
@ianstewart
Copy link
Contributor

@simison let's give it a shot. :)

@simison
Copy link
Member Author

simison commented May 11, 2021

Needs rebase, config moved to

{
"title": "Reynolds",
"slug": "reynolds",
"template": "reynolds",
"theme": "rockfield",
"fonts": {
"headings": "Playfair Display",
"base": "Fira Sans"
},
"categories": [ "featured", "portfolio" ],
"is_premium": false,
"is_alpha": true,
"features": []
},

I recall there were some issues on last time we looked in to this, but now it's looking good again.

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 11, 2021
@simison simison added [Status] Needs Rebase [Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. and removed [Status] Blocked / Hold labels May 11, 2021
Copy link
Member

@alshakero alshakero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected and font replacement works too.

@alshakero alshakero force-pushed the update/re-enable-reynolds-design branch from 21fdb67 to 5ea0e08 Compare May 11, 2021 12:34
@alshakero alshakero merged commit 824c0b3 into trunk May 11, 2021
@alshakero alshakero deleted the update/re-enable-reynolds-design branch May 11, 2021 13:10
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 11, 2021
@razvanpapadopol razvanpapadopol changed the title New onboarding: re-enable Reynolds design Design Picker: re-enable Reynolds design May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Signup & Account Creation All screens and flows for making a new WordPress.com account. [Goal] New Onboarding previously called Gutenboarding [Status] Needs Rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants