Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E test: Move check for the Premium Content block from Earn to Grow #49642

Merged

Conversation

andrewserong
Copy link
Member

@andrewserong andrewserong commented Feb 3, 2021

With the recent move to adding the Premium Content block to Jetpack, it looks like the block has moved in the inserter from the Earn section to the Grow section, and this caused one of the e2e tests to fail. To get the e2e tests passing again, this PR updates the check to look for the Premium Content block in the Grow section.

Changes proposed in this Pull Request

  • Move the check for the Premium Content block from the Earn section to the Grow section in the e2e test that covers its presence in the inserter.

Testing instructions

  • See if the e2e tests pass

Related to #

@matticbot
Copy link
Contributor

@andrewserong andrewserong self-assigned this Feb 3, 2021
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 3, 2021
@andrewserong andrewserong requested a review from a team February 3, 2021 03:02
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@noahtallen noahtallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we got some passing tests :)

@andrewserong andrewserong merged commit 14b7ef9 into trunk Feb 3, 2021
@andrewserong andrewserong deleted the update/e2e-move-premium-content-to-grow-section branch February 3, 2021 03:24
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 3, 2021
@apeatling
Copy link
Member

Thanks for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants