-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenboarding: reinstate Doyle design #49801
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~17 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Nope. I think we had a PR to remove that? cc @simison |
Yeah, there shouldn't be any premium fonts left and if there were, my bad they I missed them! Edit: fonts? I meant designs... |
Thanks for confirming! I've updated this to set |
855d00f
to
481d8f8
Compare
This is ready for review now, the remaining issues with Doyle (and its Headstart annotation) have now been resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Doyle is available as a theme when creating a site in
/new
- Doyle is not flagged as a premium theme
- The theme preview in the font picker looks good
- The theme's design looks good in the block editor
- The theme's design looks good in the front-end of the site (tested via "Preview" button)
Thanks for testing @ciampo! 😀 |
Screenshot
Changes proposed in this Pull Request
Outstanding issues
Note there is still an issue with button alignment: (could be the same as the issue @ianstewart raised in: p1612550526184000/1612384721.081900-slack-C013QHLF28Y)Update: fixed in D56946-code and the underlying issue is logged in: Migrated button markup causing rendering problems WordPress/gutenberg#28957CC: @ianstewart should this one still be flagged as Premium?Update: confirmed that it is not to be flagged as premium, so I've updated this to beis_premium: false
.Testing instructions
/new
and go to create a new site selecting theDoyle
designRelated to #