Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenboarding: reinstate Doyle design #49801

Merged
merged 2 commits into from
Feb 15, 2021
Merged

Conversation

andrewserong
Copy link
Member

@andrewserong andrewserong commented Feb 8, 2021

Screenshot

image

Changes proposed in this Pull Request

Outstanding issues

CC: @ianstewart should this one still be flagged as Premium? Update: confirmed that it is not to be flagged as premium, so I've updated this to be is_premium: false.

Testing instructions

  • Go to /new and go to create a new site selecting the Doyle design
  • Make sure that the design is rendering correctly in the preview in the font selection step
  • Create a new site, and make sure the design is looking correct in the editor and on the front end of the site

Related to #

@matticbot
Copy link
Contributor

matticbot commented Feb 8, 2021

@matticbot
Copy link
Contributor

matticbot commented Feb 8, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~17 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
entry-gutenboarding       +197 B  (+0.0%)      +17 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@ianstewart
Copy link
Contributor

should this one still be flagged as Premium?

Nope. I think we had a PR to remove that? cc @simison

@simison
Copy link
Member

simison commented Feb 8, 2021

Yeah, there shouldn't be any premium fonts left and if there were, my bad they I missed them!

Edit: fonts? I meant designs...

@andrewserong
Copy link
Member Author

Thanks for confirming! I've updated this to set is_premium to false.

@andrewserong andrewserong force-pushed the update/insert-doyle-design branch from 855d00f to 481d8f8 Compare February 12, 2021 02:06
@andrewserong andrewserong added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 12, 2021
@andrewserong andrewserong requested review from a team February 12, 2021 02:35
@andrewserong
Copy link
Member Author

This is ready for review now, the remaining issues with Doyle (and its Headstart annotation) have now been resolved.

Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Doyle is available as a theme when creating a site in /new
    • Doyle is not flagged as a premium theme
  • The theme preview in the font picker looks good
  • The theme's design looks good in the block editor
  • The theme's design looks good in the front-end of the site (tested via "Preview" button)

@andrewserong
Copy link
Member Author

Thanks for testing @ciampo! 😀

@andrewserong andrewserong merged commit c35e300 into trunk Feb 15, 2021
@andrewserong andrewserong deleted the update/insert-doyle-design branch February 15, 2021 23:31
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants