Plugins (wpcom) fix google-analytics plugin link #5027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retrofox
added
[Status] Needs Review
|
Tested it, and the Back button works as expected. |
|
merging then. Thanks @drw158 |
scruffian
removed
the
[Status] Needs Review
lancewillett
removed
the
[Feature] Plans & Upgrades
lancewillett
added
the
[Feature] Plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 4993
The problem here is if we add
target<a>html attribute page.js doesn't handle rightly the link when the user does the click beyond that its value is_self.Please read the issue description to understand the problem and to test this solution.
cc @drw158 @adambbecker