Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins: fix google-analytics link #5085

Merged
merged 3 commits into from
Apr 28, 2016

Conversation

retrofox
Copy link
Contributor

Fix #4993

  • Fix link in google-analytics link: '/plans/features/google-analytics/{siteSlug}'
  • Fix back link in the header cake in the plans page
  • Remove unused business-plugin.jsx file

Here description and testing.

cc @drw158 @dmsnell

@retrofox retrofox added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. WPCOM Plugins labels Apr 28, 2016
@retrofox retrofox added this to the WPCOM Plugins: v1 release milestone Apr 28, 2016
@davewhitley
Copy link
Contributor

davewhitley commented Apr 28, 2016

Hm, the link works, but now the inactive plugin styles are broken (the lower opacity and gray color). I believe a is-disabled class was being added to .wpcom-plugins__premium-panel and wpcom-plugins__business-panel

#4995 (comment) For reference

@davewhitley
Copy link
Contributor

Master also has the same problem though. I'm not sure what happened. wpcalypso looks fine though.

Shall I create a new issue for the disabled plugins problem?

@davewhitley
Copy link
Contributor

Hah, actually, I was looking at a site that had the Business plan. Never mind!

@dmsnell
Copy link
Member

dmsnell commented Apr 28, 2016

Hah, actually, I was looking at a site that had the Business plan. Never mind!

I wondered if that might have been the case 😄

@dmsnell
Copy link
Member

dmsnell commented Apr 28, 2016

@retrofox :shipit:

@dmsnell dmsnell added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 28, 2016
@retrofox retrofox merged commit 5f46ad9 into master Apr 28, 2016
@retrofox
Copy link
Contributor Author

thanks guys for the review

@lancewillett lancewillett deleted the update/fix-plugins-google-analytics-link branch May 13, 2016 15:07
@lancewillett lancewillett removed the [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. label Sep 5, 2016
@lancewillett lancewillett added the [Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation. label Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants