Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPCOM Plugins: update design #5194

Merged
merged 5 commits into from
Jun 3, 2016
Merged

WPCOM Plugins: update design #5194

merged 5 commits into from
Jun 3, 2016

Conversation

davewhitley
Copy link
Contributor

@davewhitley davewhitley commented May 3, 2016 •
edited
Loading

  • Icons are now gray
  • Active icons have a green check
  • Added 3 plugins (Likes, Publicize, Polls)
  • Rearranged plugins
  • Eliminated text truncation
  • Remove blue border on section header

Fixes #5133 Fixes #5125 Fixes #4986

Before:
axmfyqxbsqqcaaaaaelftksuqmcc

After:
b7q0ybd472aaaaaelftksuqmcc

After eliminating truncation:
screen shot 2016-05-03 at 3 42 20 pm

@davewhitley davewhitley added this to the WPCOM Plugins: v1.1 milestone May 3, 2016
@davewhitley
Copy link
Contributor Author

@dmsnell As you can see in the above screenshot, I'm adding green checks to all active plugins. Right now I'm just using CSS to hide them on inactive ones. Conditionally inserting the icon in React may be a cleaner approach.

@dmsnell
Copy link
Member

dmsnell commented May 3, 2016 •
edited
Loading

thanks @drw158! I just setup the checkbox so that it will only render if the plugin is active.

Your other changes looked great.

@davewhitley davewhitley added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels May 4, 2016
davewhitley and others added 5 commits June 2, 2016 17:08
@davewhitley @dmsnell
Adding green checkmark
4efd77d 
Making icons gray
@davewhitley @dmsnell
standardizing all links, rearranging plugins, adding plugins
304d382
@davewhitley @dmsnell
Adding a nbsp on all descriptions
b3e3f50
@davewhitley @dmsnell
Eliminating truncation on titles
49e7566
@dmsnell
Conditionally show "active" checkmark on plugins
a960cd7 
Previously, CSS was being used to hide the "active" checkmarks on plugin
displays if there were disabled.

This patch conditonally renders those checkmarks so that the CSS hiding
is unnecessary.
@dmsnell dmsnell force-pushed the update/wpcom-plugins-design branch from 58844fe to a960cd7 Compare June 3, 2016 00:08
@apeatling
Copy link
Member

Looks great, nice update. Good to merge 👍

@apeatling apeatling added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jun 3, 2016
@dmsnell dmsnell merged commit 7a180b3 into master Jun 3, 2016
@dmsnell dmsnell deleted the update/wpcom-plugins-design branch June 3, 2016 17:55
@lancewillett lancewillett removed the [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. label Sep 5, 2016
@lancewillett lancewillett added the [Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation. label Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation.
Projects
None yet
Milestone
Plans: WP.com Plugins
Development

Successfully merging this pull request may close these issues.
5 participants
@davewhitley @dmsnell @apeatling @lancewillett @matticbot