Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Simplify generation of assets list #56195

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Conversation

scinos
Copy link
Contributor

@scinos scinos commented Sep 13, 2021

Changes proposed in this Pull Request

Replace name assets-evergreen.json with just assets.json

Now that fallback is gone, the -evergreen suffix doesn't add any value.

Testing instructions

  • Checkout this branch and check yarn start works
  • Checkout this branch and check yarn build-clien && ./bin/loader-stats.js works
  • Verify tests are green

@scinos scinos requested a review from a team September 13, 2021 10:20
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 13, 2021
@github-actions
Copy link

github-actions bot commented Sep 13, 2021

Copy link
Member

@jsnajdr jsnajdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@scinos scinos merged commit 17451e5 into trunk Sep 13, 2021
@scinos scinos deleted the build/cleanup-assets-list branch September 13, 2021 11:37
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants