Homepage replacement on Atomic: Toggle modal based on flag #65976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the homepage modal on Atomic behind the
themes/atomic-homepage-replace
flag.Note about the previews
**The current behaviour of the preserve homepage option doesn't seem to be working** Please make a comment on this PR about this subject. I think that it's best to remove the previews on the modal on Atomic on a subsequent PR.
Temporary steps until wpcomsh PR is merged
This is the
wpcomsh
PR that's needed in order for the modal to work: 1046-gh-Automattic/wpcomsh. If it's merged ignore the following steps and go directly toTesting
./atomic/wpcom-dev-blogs/
on mc.wpcomsh
PR on your dev environment. 1046-gh-Automattic/wpcomshWPCOMSH_DEVMODE=1 make clean build
rsync -avze ssh --delete build/wpcomsh [YOUR WOA SITE]@sftp.wp.com:htdocs/wp-content/mu-plugins
Testing
wpcomsh
PR is not merged)./themes/[YOUR_SITE]?flags=themes/atomic-homepage-replace
.Activate
./themes/[YOUR_SITE]
.Activate
.Related to #65060 and #56869