Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run eslint --fix on repo #72303

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Run eslint --fix on repo #72303

merged 1 commit into from
Jan 19, 2023

Conversation

noahtallen
Copy link
Contributor

@noahtallen noahtallen commented Jan 19, 2023

Proposed Changes

Result of running yarn eslint . --fix on the repo.

Testing Instructions

CI

@noahtallen noahtallen requested a review from a team January 19, 2023 00:05
@noahtallen noahtallen requested review from a team as code owners January 19, 2023 00:05
@noahtallen noahtallen requested review from a team and razvanpapadopol and removed request for a team January 19, 2023 00:05
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 19, 2023
@matticbot
Copy link
Contributor

matticbot commented Jan 19, 2023

@noahtallen noahtallen self-assigned this Jan 19, 2023
@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit eslint-fix on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@matticbot
Copy link
Contributor

This PR modifies the release build for wpcom-block-editor

To test your changes on WordPress.com, run install-plugin.sh wpcom-block-editor eslint-fix on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-l4k-p2

Copy link
Contributor

@worldomonation worldomonation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot

There's a failure in client/lib/notifications/note-block-parser.js though.

@noahtallen
Copy link
Contributor Author

Ah yeah! I originally ran this under the Node 18 PR, so I'm going to re do it without that just to be sure this can land first.

@matticbot
Copy link
Contributor

matticbot commented Jan 19, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~14 bytes removed 📉 [gzipped])

name                 parsed_size           gzip_size
entry-gutenboarding       -131 B  (-0.0%)      -14 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for notifications

To test your changes on WordPress.com, run install-plugin.sh notifications eslint-fix on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-elI-p2

@noahtallen noahtallen merged commit fb0aab8 into trunk Jan 19, 2023
@noahtallen noahtallen deleted the eslint-fix branch January 19, 2023 00:32
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 19, 2023
@tyxla
Copy link
Member

tyxla commented Jan 19, 2023

Amazing, thanks Noah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants