-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative Support Widget Experiment #78282
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~3386 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~54002 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~76337 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
0ba990a
to
532a254
Compare
- Section Name is sent to the server - Enter key now works (instead of clicking send every time) - Hide it behind a feature flag (odysseus) - Give default behaviour with nudge: none
…ng for a12s launch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great first pass. Looking forward to it evolving quickly.
onClick={ () => { | ||
sendNudge( { | ||
nudge: 'email-comparison', | ||
initialMessage: `I see you want to an email provider to your domain ${ domain.name }. I can give you a few tips on how to do that.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are missing a verb here, I assume this needs to be “want to add an email provider”?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I will fix it with the next changes I commit :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @AllTerrainDeveloper.
This is an alternative support widget experiment for demo purposes and accessible to Automatticians only.
It needs D113721-code applied in your sandbox in order to work.